drivers: flash: stm32 xspi and ospi: early init exit for memap mode #82088
+30
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
de-nordic,
erwango,
FRASTM,
gautierg-st,
marwaiehm-st,
mathieuchopstm and
rghaddab
GeorgeCGV
force-pushed
the
stm32_ospi_memap_early_init_exit
branch
4 times, most recently
from
d78a967
to
0fd925a
Compare
|
Compliance checks fail due to " |
FRASTM
previously approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Probably same approach is valid for the https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/flash/flash_stm32_xspi.c
Due to recent CI change. Please rebase |
Exit the init earlier when OSPI is in memory map mode. Avoid unnecessary checks and prevent pin reconfiguration that might cause line spikes. Clock check beforehand is preserved. Remove '\n' from the LOG_DBG string. Signed-off-by: Georgij Cernysiov <[email protected]>
Exit the init earlier when XSPI is in memory map mode. Avoid unnecessary checks and prevent pin reconfiguration that might cause line spikes. Clock check beforehand is preserved. Remove '\n' from the LOG_DBG string. Signed-off-by: Georgij Cernysiov <[email protected]>
GeorgeCGV
force-pushed
the
stm32_ospi_memap_early_init_exit
branch
from
0fd925a
to
b33fe56
Compare
GeorgeCGV
changed the title
|
I rebased and added the same early exit to the xSPI driver. However, an unrelated storage flash map test fails. |
FRASTM
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exit the init earlier when OSPI or xSPI is in memory map mode. Avoid unnecessary checks and prevent pin reconfiguration
that might cause line spikes (e.g. when pin config differs between an application and a bootloader). Clock check beforehand is preserved (mainly for non-mem-map mode operation as we access the register. When the clock is not enabled in mem map mode it will be noticed way earlier).
Misc: removed
\nfrom the LOG_DBG string.